Repository navigation
remove some of the python2 compat and update syntax - #230
Merged
neersighted merged 1 commit intoNov 16, 2021
Merged
Conversation
danieleades
changed the title
neersighted
requested changes
Nov 13, 2021
neersighted
left a comment
neersighted
left a comment
Member
There was a problem hiding this comment.
Looks good overall with one exception -- the refactor of the TemporaryDirectory wrapper is incorrect.
danieleades
force-pushed
the
refactor/remove-python2-compat
branch
from
November 15, 2021 16:33
99112fb to
7a6d07b
Compare
Contributor
Author
|
is there a reason not to simply add the pyupgrade hook? |
Member
|
python-poetry/poetry#4758 adds the hook for |
2 tasks
Member
The intention is to copy the automation from poetry once I've got it dialled in to everyone's satisfaction. Still, a PR adding pyupgrade would not be unwelcome -- I just plan to replace the |
danieleades
force-pushed
the
refactor/remove-python2-compat
branch
3 times, most recently
from
November 16, 2021 07:25
6e2573b to
0a609f4
Compare
neersighted
previously approved these changes
Nov 16, 2021
danieleades
force-pushed
the
refactor/remove-python2-compat
branch
2 times, most recently
from
November 16, 2021 10:55
040f146 to
b8339bb
Compare
neersighted
requested changes
Nov 16, 2021
danieleades
force-pushed
the
refactor/remove-python2-compat
branch
2 times, most recently
from
November 16, 2021 12:18
949eca2 to
bb63ed0
Compare
danieleades
force-pushed
the
refactor/remove-python2-compat
branch
from
November 16, 2021 12:20
bb63ed0 to
0706fd4
Compare
neersighted
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.